pvcnt commented on code in PR #2039:
URL: https://github.com/apache/solr/pull/2039#discussion_r1410877477
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java:
##########
@@ -135,6 +140,20 @@ public class CollectionHandlingUtils {
}
}
+ /** Returns names of properties that are used to specify a number of
replicas of a given type. */
Review Comment:
I really would prefer not to bloat `Replica.Type` with methods, especially
static ones, that are not used there. Since those methods are used only from
API/Command layer, I believe that having them in a class named
`CollectionHandlingUtils` makes sense. And since they are static (this is a
different story for non-static methods, I added one as requested elsewhere in
this PR) I do not see the difference it makes to have them here or there. So I
definitely prefer not adding random util methods to a place where they do not
belong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
