cpoerschke commented on code in PR #2120:
URL: https://github.com/apache/solr/pull/2120#discussion_r1418801345
##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -100,6 +100,9 @@ grant {
permission java.lang.RuntimePermission "loadLibrary.jaas";
permission java.lang.RuntimePermission "loadLibrary.jaas_unix";
permission java.lang.RuntimePermission "loadLibrary.jaas_nt";
+ // needed by ONNX integration (TODO: there is a cleaner way to handle this)
+ permission java.lang.RuntimePermission "loadLibrary.*"; // TODO: make more
specific
+ permission java.io.FilePermission
"/Users/cpoerschke/opennlp-data/onnx/sentence-transformers/vocab.txt", "read";
// TODO: remove when no longer used
Review Comment:
I'd love to see the "films" [vector
model](https://github.com/apache/solr/tree/main/solr/example/films/vectors) as
convertible to ONNX and then we could use it e.g. for tests. But not yet looked
into details much.
##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -100,6 +100,9 @@ grant {
permission java.lang.RuntimePermission "loadLibrary.jaas";
permission java.lang.RuntimePermission "loadLibrary.jaas_unix";
permission java.lang.RuntimePermission "loadLibrary.jaas_nt";
+ // needed by ONNX integration (TODO: there is a cleaner way to handle this)
+ permission java.lang.RuntimePermission "loadLibrary.*"; // TODO: make more
specific
Review Comment:
above there's `${common.dir}` and `${common-solr.dir}` usage and i imagine
some property usage here could avoid the top-level wildcard use, but not yet
looked into details; illustration:
```suggestion
permission java.lang.RuntimePermission
"loadLibrary.${someBuildDirectory}/*";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
