[ 
https://issues.apache.org/jira/browse/SOLR-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794747#comment-17794747
 ] 

ASF subversion and git services commented on SOLR-16995:
--------------------------------------------------------

Commit 10c09d02ac9469a24f2323d46416356a70b58fb8 in solr's branch 
refs/heads/main from Vincent P
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=10c09d02ac9 ]

SOLR-16995: Associate with each replica type a property for "numReplicas" 
(#2039)

This allows to avoid repetitive code extracting number of replicas from a 
message.

> Refactor replica types to make it easier to add new ones
> --------------------------------------------------------
>
>                 Key: SOLR-16995
>                 URL: https://issues.apache.org/jira/browse/SOLR-16995
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Vincent Primault
>            Priority: Minor
>             Fix For: main (10.0)
>
>          Time Spent: 11h 50m
>  Remaining Estimate: 0h
>
> Current replica types are integrated in the code in an ad-hoc manner. 
> Consequently, it is not easy to modify the behaviour of an existing replica 
> type or to add a new one.
> I'm working on separating compute from storage (with Ilan and others), and 
> for the purpose of this project we would need to add a new replica type (or 
> _maybe_ to alter the behaviour of existing ones). This is why I would like to 
> propose some iterative refactoring steps to make it possible to do so with 
> less boilerplate.
> First PR is around making it easier to work with replica counts, i.e., the 
> number of replicas per replica type. It avoids tracking individually number 
> of replicas of a given type via individual variables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to