jdyer1 commented on PR #2099: URL: https://github.com/apache/solr/pull/2099#issuecomment-1847836841
I think we actually do have test coverage with the things you mention. The way this test is working, it still goes out to both `https://{{host}}:{{port}}/default/.well-known/openid-configuration` and then to `https:///{{host}}:{{port}}/default/jwks`. By disabling hostname verification we allow the mock host to use a self-signed certificate. I added back in the check for `hostName` as you suggest, just in case. If this seems good to you, I can commit this in a few days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
