epugh commented on code in PR #2147: URL: https://github.com/apache/solr/pull/2147#discussion_r1424506268
########## solr/solr-ref-guide/modules/configuration-guide/pages/package-manager-internals.adoc: ########## @@ -394,7 +411,9 @@ Note that the `Version` value is `"2"`, which means the plugin is updated. === How to Avoid Automatic Upgrade The default version used in any collection is always the latest. -However, setting a per-collection property in `params.json` ensures that the versions are always fixed irrespective of the new versions added. +However, setting a per-collection property in `params.json` ensures that the collection uses the same +package version (i.e., version *2.0*), irrespective of any versions larger than *2.0* that may be added to Solr Review Comment: I wonder if we should say "later" or "more recent" than, versus "larger" ########## solr/solr-ref-guide/modules/configuration-guide/pages/package-manager-internals.adoc: ########## @@ -144,12 +146,18 @@ A Package has the following attributes: For every package/version in the packages definition, there is a unique `SolrResourceLoader` instance. This is a child of the `CoreContainer` resource loader. +NOTE: Solr does not require that the version string follows any particular format - +it can be an arbitrary string or even an empty string. + === packages.json The package configurations live in a file called `packages.json` in ZooKeeper. At any given moment we can have multiple versions of a given package in the package configuration. The system will always use the latest version. -Versions are sorted by their numeric value and the highest is the latest. +Versions are sorted by their values in lexicographic order, and the largest string is considered to be the latest. + +CAUTION: Lexicographic order for version strings means that for a package with versions *1.2.0*, *1.9.0*, *1.11.0*, Review Comment: REally? Can we please get a JIRA to fix this ;-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
