janhoy commented on code in PR #2161:
URL: https://github.com/apache/solr/pull/2161#discussion_r1430542244
##########
solr/CHANGES.txt:
##########
@@ -23,6 +23,8 @@ Improvements
* SOLR-17077: When a shard rejoins leader election, leave previous election
only once to save unneeded calls to Zookeeper. (Pierre Salagnac)
+* SOLR-17105: A base "location" is no required when using
LocalFileSystemRepository for backup/restore. (Houston Putman, David Smiley,
janhoy)
Review Comment:
```suggestion
* SOLR-17105: A base "location" is now required when using
LocalFileSystemRepository for backup/restore. (Houston Putman, David Smiley,
janhoy)
```
##########
solr/core/src/test/org/apache/solr/cloud/api/collections/BackupRestoreApiErrorConditionsTest.java:
##########
@@ -72,7 +78,8 @@ public static void setUpClass() throws Exception {
final RequestStatusState backupState =
CollectionAdminRequest.backupCollection(COLLECTION_NAME, BACKUP_NAME)
.setRepositoryName(VALID_REPOSITORY_NAME)
- .setLocation(validBackupLocation)
+ .setLocation(fullBackupDir.toString())
+ .setLocation(validBackupLocation.toString())
Review Comment:
Why two setLocation in a row?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
