dsmiley commented on code in PR #1996:
URL: https://github.com/apache/solr/pull/1996#discussion_r1432262359
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/SelectStream.java:
##########
@@ -308,6 +327,13 @@ public Tuple read() throws IOException {
workingForEvaluators.put(fieldName, original.get(fieldName));
if (selectedFields.containsKey(fieldName)) {
workingToReturn.put(selectedFields.get(fieldName),
original.get(fieldName));
+ } else {
+ for (String globPattern : selectedFieldGlobPatterns) {
+ if (GlobPatternUtil.matches(globPattern, fieldName)) {
Review Comment:
Shouldn't SelectStream also use SolrReturnFields and not use lower level
GlobPattern stuff (it's something SRF can handle)?
Disclaimer: I haven't looked at this PR in a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
