janhoy commented on code in PR #2175:
URL: https://github.com/apache/solr/pull/2175#discussion_r1442292722
##########
solr/core/src/java/org/apache/solr/schema/IndexSchema.java:
##########
@@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map<String,
Collection<String>> copyFields)
throw new SolrException(ErrorCode.SERVER_ERROR, msg);
}
+ /** Informs analyzers used by a fieldType. */
+ protected void informResourceLoaderAwareObjectsForFieldType(FieldType
fieldType) {
+ // must inform any sub-components used in the
+ // tokenizer chain if they are ResourceLoaderAware
+ if (!fieldType.supportsAnalyzers()) return;
+
+ Analyzer indexAnalyzer = fieldType.getIndexAnalyzer();
Review Comment:
Note that this entire method is *moved* over from `ManagedIndexSchema`, and
I have not modified it or attempted to optimize it. May we leave improvements
to anoter PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
