Jan Høydahl created SOLR-17111:
----------------------------------
Summary: Standardize system property naming
Key: SOLR-17111
URL: https://issues.apache.org/jira/browse/SOLR-17111
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Jan Høydahl
Followup from SOLR-15960.
This Jira will standardize naming of system properties in use by Solr with rules
* Lowercase {{[a-z0-9\.]}} only
* All props start with {{solr.}}
* All props === env.var (when uppercased and {{{}.replace("-","_"){}}})
See
[EnvToSyspropMappings.properties|https://github.com/apache/solr/blob/main/solr/core/src/resources/EnvToSyspropMappings.properties]
for a list of identified non-standard system property names. It may not be
complete. And some are impossible to change, such as
{{{}SOLR_PORT=jetty.port{}}}.
I think it makes sense to add one child-task for each of the vars we want to
standardize, so we can target one variable/property at a time. The process will
be (using {{enable.packages}} as example:
# Make our code and docs use "solr.enable.packages" everywhere
# Make sure the old sysprop still works in 9.x (This may be automated using
the properties file above)
# Make a note in 9.x upgrade notes that "-Denable.packages" is deprecated
# Add a section to 10.0 major changes that "-Denable.packages" no longer works
from 10.0
# Add a test? Perhaps it is enough to test the EnvUtils logic, i.e. that no
matter which way you set the env/property our code
{{EnvUtils.getProp("solr.enable.packages")}} gets hold of it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
