pjmcarthur commented on code in PR #2126:
URL: https://github.com/apache/solr/pull/2126#discussion_r1450781121
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -211,6 +215,17 @@ private NodeConfig(
if (null == this.solrHome) throw new NullPointerException("solrHome");
if (null == this.loader) throw new NullPointerException("loader");
+ if (this.clusterPlugins != null
+ && this.clusterPlugins.length > 0
+ && !ClusterPluginsSourceConfigurator.resolveClassName()
+ .equals(NodeConfigClusterPluginsSource.class.getName())) {
+ throw new SolrException(
Review Comment:
I don't think we'd be doing users any favors by allowing/encouraging
ambiguity in configs, and ignoring some of it based on settings. IMO the
exception is correct here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
