janhoy commented on code in PR #2193:
URL: https://github.com/apache/solr/pull/2193#discussion_r1450967237
##########
solr/modules/s3-repository/src/java/org/apache/solr/s3/S3BackupRepositoryConfig.java:
##########
@@ -59,7 +58,7 @@ public S3StorageClient buildClient() {
}
private static String getStringConfig(NamedList<?> config, String property) {
- String envProp = System.getenv().get(toEnvVar(property));
+ String envProp = EnvUtils.getProp(property);
Review Comment:
No need for `toEnvVar(prop)` here (which does `solr.foo.bar ->
SOLR_FOO_BAR`) since we can rely on the fact that `EnvUtils.getProp` will
obtain `solr.foo.bar` even when set as env `SOLR_FOO_BAR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
