pjmcarthur opened a new pull request, #2204: URL: https://github.com/apache/solr/pull/2204
https://issues.apache.org/jira/browse/SOLR-15960 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description The test run in #2126 (and #2202, I think) has failed for some Collection creation tests. The stack trace is `Caused by: java.lang.NullPointerException: key can't be null at java.base/java.lang.System.checkKey(System.java:956) at java.base/java.lang.System.getProperty(System.java:826) at org.apache.solr.common.util.EnvUtils.getPropWithCamelCaseFallback(EnvUtils.java:169) at org.apache.solr.common.util.EnvUtils.getProp(EnvUtils.java:153) at org.apache.solr.common.util.PropertiesUtil.substitute(PropertiesUtil.java:68) ` It seems that `getPropWithCamelCaseFallback` has returned a null value for a key name. I suspect this may be caused by a concurrency issue causing an inconsistent view of the map state between threads, as the tests that failed use multiple nodes. # Solution Changed camelCaseToDotsMap to be a ConcurrentHashMap to eliminate possible race conditions. # Tests I have not been able to reproduce this reliably in a test. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. (I attached this to the existing Jira) - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
