pvcnt commented on code in PR #2203:
URL: https://github.com/apache/solr/pull/2203#discussion_r1459038206
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -999,36 +999,6 @@ public static String getShardLeadersElectPath(String
collection, String shardId)
+ (shardId != null ? ("/" + shardId + "/" + ELECTION_NODE) : "");
}
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection, String shardId, String thisCoreNodeName) {
- return getReplicaProps(collection, shardId, thisCoreNodeName, null);
- }
-
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection,
- String shardId,
- String thisCoreNodeName,
- Replica.State mustMatchStateFilter) {
- return getReplicaProps(collection, shardId, thisCoreNodeName,
mustMatchStateFilter, null);
- }
-
- public List<ZkCoreNodeProps> getReplicaProps(
- String collection,
- String shardId,
- String thisCoreNodeName,
- Replica.State mustMatchStateFilter,
- Replica.State mustNotMatchStateFilter) {
- // TODO: We don't need all these getReplicaProps method overloading. Also,
it's odd that the
Review Comment:
Got a rid of that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
