gerlowskija commented on code in PR #2201:
URL: https://github.com/apache/solr/pull/2201#discussion_r1459224634
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionRequiringSolrRequest.java:
##########
@@ -19,13 +19,15 @@
import org.apache.solr.client.solrj.SolrRequest;
import org.apache.solr.client.solrj.SolrResponse;
-public abstract class DataStoreSolrRequest<T extends SolrResponse> extends
SolrRequest<T> {
- public DataStoreSolrRequest(METHOD m, String path) {
+/** Parent {@link SolrRequest} class that requires a (target) collection or
core. */
Review Comment:
Done 👍
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##########
@@ -98,9 +98,9 @@ public B withFollowRedirects(boolean followRedirects) {
return getThis();
}
- /** Sets a default data store for core- or collection-based requests. */
- public B withDefaultDataStore(String defaultCoreOrCollection) {
- this.defaultDataStore = defaultCoreOrCollection;
+ /** Sets a default for core- or collection-based requests. */
Review Comment:
Done 👍
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1197,9 +1197,9 @@ public Builder withResponseParser(ResponseParser
responseParser) {
return this;
}
- /** Sets a default data store for core- or collection-based requests. */
- public Builder withDefaultDataStore(String defaultCoreOrCollection) {
- this.defaultDataStore = defaultCoreOrCollection;
+ /** Sets a default for core- or collection-based requests. */
Review Comment:
Done 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
