[
https://issues.apache.org/jira/browse/SOLR-17116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808761#comment-17808761
]
ASF subversion and git services commented on SOLR-17116:
--------------------------------------------------------
Commit 2a85f47c2093855f6cfe6410ccfc343889e6b7a3 in solr's branch
refs/heads/main from Jason Gerlowski
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=2a85f47c209 ]
SOLR-17116: Fix INSTALLSHARDDATA async reporting (#2188)
Prior to this commit, failures in asynchronous 'INSTALLSHARDDATA'
commands weren't properly detected. Instead the task was always labeled
as 'completed', even when it failed.
Ultimately, this occurred because the overseer processing for this
command ignored the output of per-core requests. Incorporating these
responses into the overseer "results" allows task operation to be
correctly classified and reported.
> Async INSTALLSHARDDATA requests never report failure
> -----------------------------------------------------
>
> Key: SOLR-17116
> URL: https://issues.apache.org/jira/browse/SOLR-17116
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 9.4
> Reporter: Jason Gerlowski
> Priority: Minor
> Attachments: reproduce.sh
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When run synchronously, INSTALLSHARDDATA failures are reported reasonably
> back to users.
> {code}
> $ curl -ilk -X GET
> 'http://localhost:8983/solr/admin/collections?action=INSTALLSHARDDATA&collection=colltoinstall&shard=shard1&location=$path'
> HTTP/1.1 500 Server Error
> Content-Type: application/json;charset=utf-8
> Content-Length: 5443
> {
> "responseHeader":{
> "status":500,
> "QTime":227
> },
> "error":{
>
> "metadata":["error-class","org.apache.solr.common.SolrException","root-error-class","org.apache.solr.common.SolrException"],
> "msg":"Could not install data to collection [colltoinstall] and shard
> [shard1]",
> "trace":"org.apache.solr.common.SolrException: Could not install data to
> collection [colltoinstall] and shard [shard1]\n\tat
> org.apache.solr.client.solrj.SolrResponse.getException(SolrResponse.java:56)\n\tat
>
> org.apache.solr.handler.admin.api.InstallShardData.installShardData(InstallShardData.java:99)\n\tat
> <...snip...>
> org.apache.solr.servlet.SolrDispatchFilter.dispatch(SolrDispatchFilter.java:254)\n\tat
> \tat java.base/java.lang.Thread.run(Thread.java:833)\n",
> "code":500
> }
> {code}
> But when run asynchronously, the response is classified as "completed"
> instead of "failed" for some reason.
> {code}
> $ curl -ilk -X GET
> 'http://localhost:8983/solr/admin/collections?action=INSTALLSHARDDATA&collection=colltoinstall&shard=shard1&location=$path&async=$asyncId'
> HTTP/1.1 200 OK
> Content-Type: application/json;charset=utf-8
> Vary: Accept-Encoding
> Content-Length: 59
> {
> "responseHeader":{
> "status":0,
> "QTime":74
> }
> }
> $ curl -ilk -X GET
> 'http://localhost:8983/solr/admin/collections?action=REQUESTSTATUS&requestid=$asyncId'
> HTTP/1.1 200 OK
> Content-Type: application/json;charset=utf-8
> Vary: Accept-Encoding
> Content-Length: 149
> {
> "responseHeader":{
> "status":0,
> "QTime":1
> },
> "status":{
> "state":"completed",
> "msg":"found [1A5B84E6] in completed tasks"
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
