cpoerschke commented on code in PR #2225:
URL: https://github.com/apache/solr/pull/2225#discussion_r1467670180
##########
solr/CHANGES.txt:
##########
@@ -30,6 +30,8 @@ Optimizations
Bug Fixes
---------------------
+* SOLR-17112: bin/solr script doesn't do ps properly on some systems
+
Review Comment:
minor: moving to Solr 9 section (assuming we're targeting that)
##########
solr/bin/solr:
##########
@@ -629,7 +629,7 @@ function solr_pid_by_port() {
# extract the value of the -Djetty.port parameter from a running Solr process
function jetty_port() {
SOLR_PID="$1"
- SOLR_PROC=$(ps -f -p "$SOLR_PID" | grep start\.jar | grep jetty\.port)
+ SOLR_PROC=$(ps -fww -p "$SOLR_PID" | grep start\.jar | grep jetty\.port)
Review Comment:
Today I learnt more about `ps` options e.g.
https://www.man7.org/linux/man-pages/man1/ps.1.html#OUTPUT_MODIFIERS info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
