pjmcarthur commented on code in PR #2226:
URL: https://github.com/apache/solr/pull/2226#discussion_r1468103699
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -155,7 +156,12 @@ private ClusterState fetchClusterState(
for (Map.Entry<String, Object> e : collectionsMap.entrySet()) {
@SuppressWarnings("rawtypes")
Map m = (Map) e.getValue();
- cs = cs.copyWith(e.getKey(), fillPrs(znodeVersion, e, m));
+ Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
+ Instant creationTime =
Review Comment:
I can make that change if you think it's preferable, it would require adding
some defensive null checks in a few places. At present, the creationTime can be
assumed to be not null in `DocCollection`.
This should be a very rare occurrence, I believe Julien's intent was to
protect against the possibility of a null value in upgrade scenarios, where an
upgraded node may receive a response from a non-upgraded node that doesn't have
a value for `creationTimeMillis`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
