dsmiley commented on PR #2221: URL: https://github.com/apache/solr/pull/2221#issuecomment-1915205945
Let's use GH links to ensure we understand each other. You are referring to [this](https://github.com/apache/solr/blob/e53bf109ba2d35e1aff6f9a5c428fff5eff63f7b/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1658)? ``` List<Query> filterList = cmd.getFilterList(); if (filterList != null && !filterList.isEmpty()) { out.docSet = DocSetUtil.getDocSet(out.docSet.intersection(getDocSet(filterList)), this); } ``` This shows that the list of filter queries goes through the filter cache. But that's true no matter what (other code paths ultimately lead to the same but in different methods deeper). The question at hand is how is the `q` param processed, which in this code gets turned into a DocSet saved to `out.docSet`. Immediately before these lines, it's populated via `getDocSet`. This is what `useFilterCache` *means*. In your PR, you added a condition to not do this, thus not use the filter cache for `q`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
