epugh commented on PR #2238:
URL: https://github.com/apache/solr/pull/2238#issuecomment-1921463577

   > Both the (documented) `example/films/films.json` and (undocumented) 
`example/films/films.xml` files work but for the (undocumented) 
`example/films/films.csv` file there's an error
   > 
   > ```
   > Caused by: org.apache.solr.common.SolrException: incorrect vector format. 
The expected format is:'[f1,f2..f3]' where each element f is a float
   >         at 
org.apache.solr.util.vector.DenseVectorParser.parseIndexVector(DenseVectorParser.java:56)
 ~[?:?]
   >         at 
org.apache.solr.util.vector.DenseVectorParser.parseVector(DenseVectorParser.java:45)
 ~[?:?]
   >         at 
org.apache.solr.util.vector.FloatDenseVectorParser.getFloatVector(FloatDenseVectorParser.java:34)
 ~[?:?]
   >         at 
org.apache.solr.schema.DenseVectorField.createField(DenseVectorField.java:266) 
~[?:?]
   >         at 
org.apache.solr.schema.DenseVectorField.createFields(DenseVectorField.java:230) 
~[?:?]
   >         at 
org.apache.solr.update.DocumentBuilder.addField(DocumentBuilder.java:67) ~[?:?]
   >         at 
org.apache.solr.update.DocumentBuilder.addOriginalField(DocumentBuilder.java:304)
 ~[?:?]
   >         at 
org.apache.solr.update.DocumentBuilder.toDocument(DocumentBuilder.java:193) 
~[?:?]
   > ```
   > 
   > i.e. probably 
https://github.com/apache/solr/blob/releases/solr/9.4.1/solr/core/src/java/org/apache/solr/util/vector/DenseVectorParser.java#L54-L57
 and perhaps it's an edge case or perhaps pipe-delimited-strings could be 
supported there too?
   > 
   > @alessandrobenedetti @epugh WDYT? I'd be happy to create a JIRA issue for 
that if it seems like a reasonable idea.
   
   It is MUCH better if the CSV format works just like json and xml...   The 
value of the CSV format starts dropping drastically the more it doesn't support 
"all the things".    In fact, all of our formats should work unless there is a 
very clear reason why it's not possible.    
   
   If it isn't fixable due to some constraint of the format, then yeah, we 
should clearly mark that in the Ref Guide.   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to