Andrzej Bialecki created SOLR-17151:
---------------------------------------
Summary: Review current usage of QueryLimits to ensure complete
coverage
Key: SOLR-17151
URL: https://issues.apache.org/jira/browse/SOLR-17151
Project: Solr
Issue Type: Sub-task
Security Level: Public (Default Security Level. Issues are Public)
Components: Query Budget
Reporter: Andrzej Bialecki
Resource usage by a query is not limited to the actual search within
{{QueryComponent}}. Other components invoked by {{SearchHandler}} may
significantly contribute to this usage, either before or after the
{{QueryComponent}}.
Those components that already use {{QueryTimeout}} either directly or
indirectly will properly observe the limits and terminate if needed. However,
other components may be expensive or misbehaving but fail to observe the limits
imposed on the end-to-end query processing.
One such obvious place where we could add this check is where the
{{SearchHandler}} loops over {{SearchComponent}-s - it should call explicitly
{{QueryLimits.shouldExit()}} to ensure that even if previously executed
component ignored the limits they will be still enforced at the
{{SearchHandler}} level. There may be other places like this, too.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]