gerlowskija commented on PR #2243:
URL: https://github.com/apache/solr/pull/2243#issuecomment-1929779151
Hi @psalagnac - this LGTM, generally.
The one thing missing IMO is some modifications to
`AbstractIncrementalBackupTest` to cover the many-shards case. I took a stab
at these locally and have code ready to share, put it looks like your branch
isn't configured to allow others to push to it:
```
$ git push psalagnac SOLR-17149:SOLR-17149
Enumerating objects: 84, done.
Counting objects: 100% (84/84), done.
Delta compression using up to 28 threads
Compressing objects: 100% (32/32), done.
Writing objects: 100% (51/51), 13.84 KiB | 4.61 MiB/s, done.
Total 51 (delta 22), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (22/22), completed with 19 local objects.
To github.com:psalagnac/solr.git
! [remote rejected] SOLR-17149 -> SOLR-17149 (**permission denied**)
error: failed to push some refs to 'github.com:psalagnac/solr.git'
```
If you're willing to accept my test changes, could you take a look at your
branch settings and let me know when they're updated? Or alternatively, if
you'd rather make the changes yourself, that's fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
