cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1481425077
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -440,8 +440,9 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
this.allowListUrlChecker = AllowListUrlChecker.create(config);
- this.collectorExecutor = ExecutorUtil.newMDCAwareCachedThreadPool(6,
- new SolrNamedThreadFactory("searcherCollector"));
+ this.collectorExecutor =
+ ExecutorUtil.newMDCAwareCachedThreadPool(
+ 6, new SolrNamedThreadFactory("searcherCollector"));
Review Comment:
1/2 I added
https://github.com/apache/solr/pull/2248/commits/dbd2d8a39616f21eac1c211d12cd73926bf46efe
commit to tentatively make this configurable. Hope you don't mind.
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -432,6 +439,12 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
this.allowPaths = allowPathBuilder.build();
this.allowListUrlChecker = AllowListUrlChecker.create(config);
+
+ this.collectorExecutor =
+ ExecutorUtil.newMDCAwareCachedThreadPool(
+ cfg.getIndexSearcherExecutorThreads(), // thread count
+ cfg.getIndexSearcherExecutorThreads(), // queue size
Review Comment:
2/2 Was thinking `IndexSearcherExecutorThreads` name based on
https://github.com/apache/lucene/blob/releases/lucene/9.9.2/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java#L228
signature and specifically no mention of 'collector' in the name since e.g.
https://github.com/apache/lucene/blob/releases/lucene/9.9.2/lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java#L82
also uses it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
