epugh commented on code in PR #2254:
URL: https://github.com/apache/solr/pull/2254#discussion_r1483374117
##########
solr/core/src/test/org/apache/solr/client/solrj/impl/ConnectionReuseTest.java:
##########
@@ -83,7 +83,8 @@ private SolrClient buildClient(CloseableHttpClient
httpClient, URL url) {
switch (random().nextInt(3)) {
case 0:
// currently, only testing with 1 thread
- return new ConcurrentUpdateSolrClient.Builder(url.toString() + "/" +
COLLECTION)
+ return new ConcurrentUpdateSolrClient.Builder(url.toString())
Review Comment:
sigh... if only a builder new what a url was and we didn't .tostring
everywhere. ;-) #beatdeadhorse
##########
solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttp2SolrClient.java:
##########
@@ -156,7 +158,7 @@ public void testSimple() throws Exception {
// Start the killed server once again
solr[1].startJetty();
// Wait for the alive check to complete
- Thread.sleep(1200);
+ Thread.sleep(1200 * 5);
Review Comment:
1.2 seconds times five?
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClientBuilderTest.java:
##########
@@ -31,6 +31,8 @@
/** Unit tests for {@link Builder}. */
public class ConcurrentUpdateSolrClientBuilderTest extends SolrTestCase {
+ private static final String ANY_BASE_URL = "http://localhost:8983/solr";;
Review Comment:
nicer!
##########
solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttp2SolrClient.java:
##########
@@ -167,17 +169,15 @@ public void testSimple() throws Exception {
}
}
- private LBHttp2SolrClient getLBHttp2SolrClient(Http2SolrClient httpClient,
String... s) {
Review Comment:
this is nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
