epugh commented on code in PR #2255:
URL: https://github.com/apache/solr/pull/2255#discussion_r1483492801
##########
solr/core/src/java/org/apache/solr/cli/PostLogsTool.java:
##########
@@ -89,9 +90,16 @@ public void runImpl(CommandLine cli) throws Exception {
}
public void runCommand(String baseUrl, String root, String credentials)
throws IOException {
+ if (URLUtil.isBaseUrl(baseUrl)) {
Review Comment:
this is interesting.. I wonder if "url" is a good name for this parameter?
I like the check... --collection-url? -collection-url.. though we dont
have any other commands with a - in the name.... at least we have the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
