cpoerschke opened a new pull request, #2258: URL: https://github.com/apache/solr/pull/2258
Subjective of course, but I think more `final` use would help with code reading/comprehension. Noticed whilst looking at #2248 changes to this method. No JIRA ticket or CHANGES.txt entry needed IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
