clayburn commented on code in PR #2264:
URL: https://github.com/apache/solr/pull/2264#discussion_r1490136801
##########
gradle/ge.gradle:
##########
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
}
+
+ tag("JDK" + System.getProperty("java.version").find(/\d+/)) // major
version
+ value("Java Vendor", System.getProperty("java.vendor"))
+ value("Java Version", System.getProperty("java.version"))
+
+ // Jenkins job name, less redundant "Solr" parts
+ String jenkinsJobName = System.getenv("JOB_NAME")
+ if (jenkinsJobName) { // looks like "Solr/Solr-Smoketest-9.5"
+ tag(jenkinsJobName.replaceAll(/Solr\W/,"")) // like "Smoketest-9.5"
+ }
+
+ //
https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
+ if (System.getenv("GITHUB_BASE_REF")) { // only exists for PRs
+ tag("PR")
+ }
+ String ghWorkflowName = System.getenv("GITHUB_WORKFLOW")
+ if (ghWorkflowName) {
+ tag(ghWorkflowName)
Review Comment:
The Common Custom User Data Gradle Plugin already adds this as a custom
value called `CI workflow`
##########
gradle/ge.gradle:
##########
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
}
+
+ tag("JDK" + System.getProperty("java.version").find(/\d+/)) // major
version
Review Comment:
For what it's worth, these JDK details are already captured in the [build
scan](https://ge.apache.org/s/iria4ppalnbdo#infrastructure). This information
will show up in build scan comparisons as well. But capturing as tags and value
is nice if you want the ability to filter on these values.
##########
gradle/ge.gradle:
##########
@@ -27,6 +31,25 @@ gradleEnterprise {
obfuscation {
ipAddresses { addresses -> addresses.collect { address ->
"0.0.0.0"} }
}
+
+ tag("JDK" + System.getProperty("java.version").find(/\d+/)) // major
version
+ value("Java Vendor", System.getProperty("java.vendor"))
+ value("Java Version", System.getProperty("java.version"))
+
+ // Jenkins job name, less redundant "Solr" parts
+ String jenkinsJobName = System.getenv("JOB_NAME")
+ if (jenkinsJobName) { // looks like "Solr/Solr-Smoketest-9.5"
+ tag(jenkinsJobName.replaceAll(/Solr\W/,"")) // like "Smoketest-9.5"
Review Comment:
The Common Custom User Data Gradle Plugin already adds this as a custom
value called `CI job` (but without the filtering you've added).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
