[
https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818000#comment-17818000
]
Jan Høydahl commented on SOLR-6572:
-----------------------------------
[~anuragsharma] I tested your patch in the attached PR, but it causes issues
with being able to express a single space in an XML value, so abandoning that
solution.
This may or may not change if we decide to change our XML parsing library in
the future.
So letting each config consumer do its own trim() for now seems like the safest.
> lineshift in solrconfig.xml is not supported
> --------------------------------------------
>
> Key: SOLR-6572
> URL: https://issues.apache.org/jira/browse/SOLR-6572
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.8.1
> Reporter: Fredrik Rodland
> Assignee: Jan Høydahl
> Priority: Major
> Labels: difficulty-easy, impact-low, solrconfig.xml
> Attachments: SOLR-6572.patch, SOLR-6572.unittest
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This has been a problem for a long time, and is still a problem at least for
> SOLR 4.8.1.
> If lineshifts are introduced in some elements in solrconfig.xml SOLR fails to
> pick up on the values.
> example:
> ok:
> {code}
> <requestHandler name="/replication" class="solr.ReplicationHandler"
> enable="${enable.replication:false}">
> <lst name="slave">
> <str
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}</str>
> {code}
> not ok:
> {code}
> <requestHandler name="/replication" class="solr.ReplicationHandler"
> enable="${enable.replication:false}">
> <lst name="slave">
> <str
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}
> </str>
> {code}
> Other example:
> ok:
> {code}
> <str
> name="shards">localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr</str>
> {code}
> not ok:
> {code}
> <str name="shards">
> localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr
> </str>
> {code}
> IDEs and people tend to introduce lineshifts in xml-files to make them
> prettyer. SOLR should really not be affected by this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
