[
https://issues.apache.org/jira/browse/SOLR-17147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818538#comment-17818538
]
ASF subversion and git services commented on SOLR-17147:
--------------------------------------------------------
Commit 8a427ebc606d7967bcaaef30a9449bc0bf61b25b in solr's branch
refs/heads/branch_9x from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8a427ebc606 ]
SOLR-17159: Untangle PostTool and SimplePostTool code (#2275)
* Copied unit tests from SimplePostToolTest to PostToolTest
* add a --dry-run mode that simulates sending documents to Solr
* Missed a few more places with -commit not needed post SOLR-17147 being
completed
* clean up our code base to have fewer warnings about code quality.
* Update SolrCloudExampleTest to use the PostTool instead of simulating it's
usage.
* Make the long form of -url expliciting a --solr-update-url to be clear what
it's for.
> To commit or not to commit? That is the question on bin/solr post
> ------------------------------------------------------------------
>
> Key: SOLR-17147
> URL: https://issues.apache.org/jira/browse/SOLR-17147
> Project: Solr
> Issue Type: Sub-task
> Components: cli
> Affects Versions: 9.5
> Reporter: Eric Pugh
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: main (10.0), 9.6.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The way we have set up most boolean options in the bin/solr is that you
> specific the option to mean "true". Versus doing a "option=true" or
> "option=false". In the bin/post command, the commit is a explicit
> true/false, and if you don't specifiy it, then there is automatically a
> commit. However, with bin/solr post, if you don't specify -commit, then you
> don't get a commit.
> Which makes sense from how the options are laid out "yes I want to opt into a
> commit", however I suspect the vast majority of users who use the command
> will immediatly go look for the doc, and wonder why it isn't visible.. which
> is proably why bin/post commits if you don't specify it.
> Our options are to have an explicit -commit=true/false OR we commit by
> default and have a -nocommit option.
> I guess I am leaning towards having a -nocommit as a boolean option, so that
> wihtout it you get the commit...
> Fortunantly optimize story is better. by default we do NOT issue an
> optimize, but you can do -optimize to requiest that ;-).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
