[
https://issues.apache.org/jira/browse/SOLR-17172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819400#comment-17819400
]
David Smiley commented on SOLR-17172:
-------------------------------------
[~hossman] had identified that my changes in recent 9.x (to account for Lucene
changes) had the down side that some code that touches the index would no
longer be governed by the timeAllowed. Like faceting, probably. This isn't to
say this JIRA issue here couldn't find something that deserves additional
checks, but I suspect the ideal fix should be to find a way to incorporate
checks when accessing the index (i.e. at a lower level), as it was done with
ExitableDirectoryReader. I'm actually surprised to see the PR here touching
SpellCheckComponent -- even that one will run queries (invoking
IndexSearcher.search) and should thus already be checked adequately; no?
> Add QueryLimits termination to existing heavy SearchComponent-s
> ---------------------------------------------------------------
>
> Key: SOLR-17172
> URL: https://issues.apache.org/jira/browse/SOLR-17172
> Project: Solr
> Issue Type: Sub-task
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The purpose of this ticket is to review the existing {{SearchComponent}}-s
> that perform intensive tasks to see if they could be modified to check the
> {{QueryLimits.shouldExit()}} inside their execution.
> This is not meant to be included in tight loops but to prevent individual
> components from completing multiple stages of costly work that will be
> discarded anyway on the exit from the component due to the exceeded limits
> (SOLR-17151).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
