gus-asf commented on PR #2301: URL: https://github.com/apache/solr/pull/2301#issuecomment-1969475841
I haven't taken time to verify it but I presume the removal of commons-io would have also removed references to it from NOTICE.txt? If we are pulling their code back in that has to return. If it was missed and still is there, that's good. Either way, there's a risk that at a later date someone will audit NOTICE.txt, not find commons-io in the output of `./gradlew dependencies` and clean it up... how do we prevent that? (I don't see any changes to NOTICE.txt in this pr) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
