dsmiley commented on code in PR #2290: URL: https://github.com/apache/solr/pull/2290#discussion_r1508083954
########## solr/core/src/java/org/apache/solr/handler/component/ExpandComponent.java: ########## Review Comment: You and I are old-timers here; we know getSlowAtomicReader won't be an issue for this use-case. Code everywhere creates arrays / lists / maps. Any way, my concern is that your rationale seems haphazard to add checks here there and everywhere instead of being based on real-world experience of what is actually slow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
