magibney commented on code in PR #1964:
URL: https://github.com/apache/solr/pull/1964#discussion_r1513378129
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -1679,19 +1698,21 @@ public static String getCollectionPath(String coll) {
* @see ZkStateReader#unregisterCore(String)
*/
public void registerCore(String collection) {
- AtomicBoolean reconstructState = new AtomicBoolean(false);
+ AtomicReference<StateWatcher> newWatcherRef = new AtomicReference<>();
collectionWatches.compute(
collection,
(k, v) -> {
if (v == null) {
- reconstructState.set(true);
- v = new StatefulCollectionWatch();
+ StateWatcher stateWatcher = new StateWatcher(collection);
Review Comment:
Curious, is there a reason to prefer this beyond style? Style-wise I
somewhat prefer _not_ writing to a volatile variable and then reading back from
it ... but because the `StatefulCollectionWatch` instance is not accessible
from other threads at this point there's no functional issue with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
