dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1525398141
##########
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##########
@@ -261,22 +260,23 @@ public String getMessage() {
}
}
- private static HttpClient createHttpClient(
- SolrCore core,
- String httpBasicAuthUser,
- String httpBasicAuthPassword,
- boolean useCompression) {
+ private Http2SolrClient createHttpClient(
+ SolrCore core, String httpBasicAuthUser, String httpBasicAuthPassword,
String leaderBaseUrl) {
final ModifiableSolrParams httpClientParams = new ModifiableSolrParams();
Review Comment:
I did some digging here. IndexFetcher can be configured with
httpBasicAuthUser and httpBasicAuthPassword in its solrconfig.xml based
configuration however this isn't document, and seems rather ancient / legacy to
me. Let's just drop this. Not sure it's even worth mentioning in upgrade
notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
