alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1529011079
##########
solr/core/src/java/org/apache/solr/search/ReRankCollector.java:
##########
@@ -129,21 +129,25 @@ public TopDocs topDocs(int start, int howMany) {
ScoreDoc[] mainScoreDocs = mainDocs.scoreDocs;
ScoreDoc[] mainScoreDocsClone =
- (reRankScaler != null && reRankScaler.scaleScores())
- ? deepCloneAndZeroOut(mainScoreDocs)
- : null;
+ deepClone(mainScoreDocs, reRankScaler != null &&
reRankScaler.scaleScores());
Review Comment:
I agree, change is coming in the next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
