janhoy commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1530237610
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##########
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for configuring {@linkplain SolrHttpClientBuilder}. This
relies on the internal
- * HttpClient implementation and is subject to change.
- *
- * @lucene.experimental
+ * Factory interface for configuring {@linkplain SolrHttpClientBuilder}.
Review Comment:
> Firstly; IMO `HttpClientBuilderFactory` and `SolrHttpClientBuilder` ought
not to be in SolrJ because they are only used for inter-node communication
within Solr.
Good point, I'll look into this separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
