alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530701074
##########
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##########
@@ -234,6 +236,13 @@ protected static boolean scoreSingleHit(
scorer.getDocInfo().setOriginalDocScore(hit.score);
hit.score = scorer.score();
+ if (QueryLimits.getCurrentLimits()
+ .maybeExitWithPartialResults(
+ "Learning To Rank rescoring -"
+ + " The full reranking didn't complete."
+ + " If partial results are tolerated the reranking got
reverted and all documents preserved their original score and ranking.")) {
Review Comment:
I agree, having two labels would help a lot, I don't like the message
either. But I think it would be better to bake this first and then introduce
the maybeExitWithPartialResults with double labels in a separate pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
