epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1532281318
##########
solr/core/src/java/org/apache/solr/spelling/WordBreakSolrSpellChecker.java:
##########
@@ -62,15 +62,15 @@ public class WordBreakSolrSpellChecker extends
SolrSpellChecker {
public static final String PARAM_MIN_BREAK_WORD_LENGTH = "minBreakLength";
/** See {@link BreakSuggestionTieBreaker} for options. */
- public static final String PARAM_BREAK_SUGGESTION_TIE_BREAKER =
"breakSugestionTieBreaker";
+ public static final String PARAM_BREAK_SUGGESTION_TIE_BREAKER =
"breakSuggestionTieBreaker";
Review Comment:
Good catch... In your suggested commit you don't have the warning
right? Okay, I guess what the plan is is to add the warning for the
deprecation.. commit this and backport, and then in main we remove the
mispelled variable. and mention that "breaking change" in the upgrade notes
to 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
