dsmiley commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1546911504
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -469,6 +531,23 @@ protected String
allProcessorSupportedContentTypesCommaDelimited(
.collect(Collectors.joining(", "));
}
+ protected static class HttpSolrClientCancellable implements Cancellable {
Review Comment:
Okay. Note the old API is on exactly one class a user might use; it's being
expanded here. But at least it's only other Http subclasses; isn't spreading
further. If you can mark these methods Deprecated here (to be replaced by
something coming (soon?)), people will be forewarned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
