Michael Gibney created SOLR-17222:
-------------------------------------

             Summary: QueryResponseWriterUtil.NonFlushingStream should support 
bulk write methods
                 Key: SOLR-17222
                 URL: https://issues.apache.org/jira/browse/SOLR-17222
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
    Affects Versions: 9.5.0, main (10.0)
            Reporter: Michael Gibney


All text responses (non-javabin) are currently serialized through 
{{QueryResponseWriterUtil.NonFlushingStream}}. The minimal method override in 
that class means that every byte written on all text responses is iterated and 
copied byte-for-byte.

It is trivial to extend {{FilterOutputStream}} and override the bulk write 
methods, eliminating this potential bottleneck. This came on my radar while 
doing [general investigation into response serialization 
slowness|https://github.com/apache/solr/pull/1440#issuecomment-1462597683]. I 
haven't bothered to benchmark this, but it's a trivial change and could only be 
a good thing, in terms of performance.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to