dsmiley commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1550359158
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -445,6 +447,17 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
cfg.getIndexSearcherExecutorThreads(), // thread count
cfg.getIndexSearcherExecutorThreads(), // queue size
new SolrNamedThreadFactory("searcherCollector"));
+ ((ExecutorUtil.MDCAwareThreadPoolExecutor)
collectorExecutor).setRejectedExecutionHandler(new RejectedExecutionHandler() {
Review Comment:
I think that's an anti-pattern or broken and isn't what I meant in JIRA. We
could use a SynchronousQueue (with fairness) if we want to block for a thread
-- probably what we should do. FYI that queue is the default for
`Executors.newCachedThreadPool()`. The "caller runs" behavior I meant could
be done via an ExecutorService delegate that catches RejectedException and
simply runs the Runnable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
