[
https://issues.apache.org/jira/browse/SOLR-17189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835722#comment-17835722
]
ASF subversion and git services commented on SOLR-17189:
--------------------------------------------------------
Commit fd54d2a7e692d30f01a341030c3401880d2c586d in solr's branch
refs/heads/branch_9x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=fd54d2a7e69 ]
SOLR-17189: Fix DockMakerTest.testRealisticUnicode (#2327)
These strings must not have whitespace.
Includes a fix for the non-repeatability of the randomness. It's not perfect --
the RandomizedContext seed isn't being passed in unless it is set explicitly
via the standard tests.seed property.
(cherry picked from commit 453a23b7e9e0610a17ceb8b6eed56946c57ffadf)
> DockMakerTest.testRealisticUnicode fails from whitespace assumption
> -------------------------------------------------------------------
>
> Key: SOLR-17189
> URL: https://issues.apache.org/jira/browse/SOLR-17189
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: benchmarks
> Reporter: David Smiley
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> DockMakerTest.testRealisticUnicode fails 1-2% of the time --
> [link|https://ge.apache.org/scans/tests?search.timeZoneId=America%2FNew_York&tests.container=org.apache.solr.bench.DockMakerTest&tests.test=testRealisticUnicode].
> {quote}java.lang.AssertionError: expected:<6> but was:<7>
> at __randomizedtesting.SeedInfo.seed([C5136F274AFF3ADD:95FFEBF499446D74]:0)
> •••
> at
> org.apache.solr.bench.DockMakerTest.testRealisticUnicode(DockMakerTest.java:189){quote}
> It seems clear it's because it assumes that the "realistic unicode" chars
> won't match the regexp: {{\s}}. A single space char is used to join the
> words but maybe this or other whitespace chars are in those unicode codepoint
> blocks.
> Additionally, it's frustrating that this particular benchmark framework
> doesn't honor tests.seed in its generation of random data and thus it's hard
> to reproduce the failure. That ought to be fixed as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
