epugh commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1569186974
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -422,7 +422,10 @@ public CloudHttp2SolrClient build() {
}
} else if (!solrUrls.isEmpty()) {
try {
- stateProvider = new Http2ClusterStateProvider(solrUrls,
httpClient);
+ if (this.internalClientBuilder != null) {
+ this.httpClient = internalClientBuilder.build();
Review Comment:
thanks for chiming in... so, this change is making my TestExportTool blow
up with unclosed httpclients.. I've banged my head on this for a LONG time,
and not making headway. What I can say is that the test with the BasicAuth
demonstrates the problem, but I can't grok the soluiton... @stillalex I would
love your ideas if you wanted to take a stab at it.. it felt like such an
easy fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
