cpoerschke commented on code in PR #2437:
URL: https://github.com/apache/solr/pull/2437#discussion_r1589231122
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -276,6 +277,7 @@ public MiniSolrCloudCluster(
Objects.requireNonNull(securityJson);
this.baseDir = Objects.requireNonNull(baseDir);
this.jettyConfig = Objects.requireNonNull(jettyConfig);
+ this.solrXml = solrXml == null ? DEFAULT_CLOUD_SOLR_XML : solrXml;
Review Comment:
Wondering if the similar logic at lines 491-493/492-494 can be removed now
then?
edit: or rather not removed but amended i.e. use passed in `solrXml` if
non-null and `this.solrXml` otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
