jdyer1 commented on code in PR #2435:
URL: https://github.com/apache/solr/pull/2435#discussion_r1589744476
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpJdkSolrClient.java:
##########
@@ -238,7 +238,7 @@ private PreparedRequest prepareGet(
validateGetRequest(solrRequest);
reqb.GET();
decorateRequest(reqb, solrRequest);
- reqb.uri(new URI(url + "?" + queryParams));
+ reqb.uri(new URI(url + queryParams.toQueryString()));
Review Comment:
I had removed the change from lines 305 and 316 as adding the `fq` parameter
you supplied the unit test only seemed to show that `GET` was broken. Likes
305 & 316 are building `POST` or `PUT` requests. On the other hand, so long as
the extra ? is removed, adding `toQueryString()` there doesn't seem to break
anything either. Yet again, I do not like "fixing" things if I cannot first
demonstrate it is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
