kotman12 commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2101745053
> > ... Tangentially, I'd like to also support additional query parameters on top of the query string, i.e. the `df` default field param, but I haven't gotten to that yet (you'll notice that `SimpleQueryParser::getParams` method is empty for now). ... > > Maybe I'm making a tangential comment here too but I'm wondering about scoping of the integration and if/how perhaps it could be split into phases e.g. an initial integration scope in this pull request and more advanced aspects somewhat considered in the approach here but deferred to later phases otherwise. E.g. additional query parameters and parallelism and aliasing and write-to-doc-list (or not-write-to-doc-list) sound like potentially more-advanced aspects? I support whatever will make this more mergeable. Some of these features were added to make the solution more adoptable by current users of lucene-monitor so I was striving for feature parity. Having said that, the aliasing feature specifically is fairly important and I'd probably want to make that the default/recommended approach. By aliasing the fields the presearcher creates you guarantee schema compatibility plus you get other benefits like compatibility with multi-pass presearcher. Having said "having said that" I'll defer to what you think is best because getting anything merged is a selling point for the viability of this approach. From the feedback I've gotten so far from the other solr committee members it sounds like they want some real users before the maintainability-threshold is reached. On the other hand I've talked to some potential users who were skeptical about using an experimental solr plugin. With a chicken and egg scenario like that, even just talking about upstream integration phases is great marketing 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
