[
https://issues.apache.org/jira/browse/SOLR-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844985#comment-17844985
]
David Smiley commented on SOLR-16505:
-------------------------------------
[~markrmiller] , based on the callers of
org.apache.solr.update.UpdateShardHandler#getRecoveryOnlyHttpClient, "recovery"
refers to IndexFetcher and RecoveryStrategy. Should this be expanded slightly
to include PeerSync (see PeerSyncWithLeader using the "default" client), or not
if there's a distinct between index replication and peer-sync with respect to
possible configuration needs like timeouts and threads. RecoveryStrategy can
initiate peer sync, after all. If you agree, shouldn't this include
SyncStrategy, which is related to PeerSync? At a glance, it's not clear why
SyncStrategy and RecoveryStrategy aren't the same thing. Javadocs could be
added to elaborate on what the scope of this recovery client is for, and also
why it exists in the first place. There's a sad "bus factor" in this part of
Solr, I think, so I really appreciate it when you share your insights.
BTW, I debate UpdateShardHandler's name
[here|https://github.com/apache/solr/pull/2351#discussion_r1595413371]; you may
have an opinion.
> Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2
> ------------------------------------------------------------------
>
> Key: SOLR-16505
> URL: https://issues.apache.org/jira/browse/SOLR-16505
> Project: Solr
> Issue Type: Sub-task
> Reporter: David Smiley
> Priority: Major
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> This method and its callers (only RecoveryStrategy) should be converted to a
> Jetty HTTP2 client.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
