gerlowskija commented on PR #2456: URL: https://github.com/apache/solr/pull/2456#issuecomment-2105176277
PackageToolTest currently fails with this PR, due to some quirky GenericSolrRequest usage in the PackageTool and PackageUtils code. It'd take a bit of untangling, but is do-able to fix. That said - rather than tweaking but retaining the GenericSolrRequest usage, I wonder if it isn't worth moving this part of the code away from GSR entirely in favor of specific SolrRequest implementations. The package APIs aren't currently covered in SolrJ, which is why this code needed to use GSR historically. But this might be a nice chance to add these APIs to SolrJ and kill "two birds with one stone". It'd be more work, but might be worth biting off. Will think it through over the weekend. If I decide to add the APIs to SolrJ, I'll do it in a separate PR that blocks this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
