dsmiley commented on code in PR #2351:
URL: https://github.com/apache/solr/pull/2351#discussion_r1599379143
##########
solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java:
##########
@@ -236,11 +246,17 @@ public SolrMetricsContext getSolrMetricsContext() {
return solrMetricsContext;
}
- // if you are looking for a client to use, it's probably this one.
+ // please use getDefaultHttpSolrClient instead.
+ @Deprecated(since = "9.6")
public HttpClient getDefaultHttpClient() {
return defaultClient;
}
+ // if you are looking for a client to use, it's probably this one.
Review Comment:
Maybe we should subclass SolrClientCache, named "ServerSolrClientCache"
(differentiating from the base one that's _mostly_ for streaming-expressions,
from which it came) and provide these methods there. That way we don't add
ever more responsibilities to CoreContainer. And it keeps these together with
other SolrClients, so developers may be looking over in SolrClientCache. Might
as well consolidate.
Perhaps defer UpdateShardHandler going away to another work item that is
"main" only. This keeps compatibility with a number of plugins. Don't want to
distract us from the overall goal of getting Apache HttpClient out of Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
