gerlowskija commented on code in PR #2470:
URL: https://github.com/apache/solr/pull/2470#discussion_r1608053404
##########
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##########
@@ -634,7 +635,7 @@ public Map<String, byte[]> getKeys() throws IOException {
// reads local keys file
private static Map<String, byte[]> _getKeys(Path solrHome) throws
IOException {
Map<String, byte[]> result = new HashMap<>();
- Path keysDir = _getRealPath(FileStoreAPI.KEYS_DIR, solrHome);
+ Path keysDir = _getRealPath(ClusterFileStore.KEYS_DIR, solrHome);
Review Comment:
Agreed, I don't love the convention either. There's several of these in
DistribFileStore though - enough that I'm worried renaming will bloat this PR
too much 😦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
