AndreyBozhko commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1608792092
##########
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##########
@@ -694,9 +694,14 @@ public <T> boolean addToCoreAware(T obj) {
}
}
+ void initConfig(SolrConfig config) {
+ assert this.config == null || this.config == config;
Review Comment:
Does this assertion make sense?
I can see that SolrConfig has a `private final` reference to the resource
loader, but is it OK to assume the opposite - that a resource loader is only
ever associated with a single SolrConfig instance? Or is it an actual invariant
that Solr enforces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
